Community Wishlist Survey 2021/Admins and patrollers/Flagged Revisions randomly fails to load user permissions

Flagged Revisions randomly fails to load user permissions

  • Problem: User permissions and rights are not loaded properly from FlagRev's configuration file in random cases. Some edits made by trusted users/admins etc. are marked as unreviewed, or the other way (!), some of these editors get permission denied messages on pages they should normally access, and other user rights related problems.
  • Who would benefit: reviewers, patrollers, admins
  • Proposed solution: unbreak the problem that the configuration file is not properly loaded
  • More comments: This is a critical bug which is not solved for more than a year now.
  • Phabricator tickets: T233561, T234743
  • Proposer: Samat (talk) 14:01, 29 November 2020 (UTC)

Discussion

Generally speaking, the Flagged Revision extension is an essential part of MediaWiki used on many wikis, and it has no maintainer or developer even for critical and security bugs for years now (see T185664). This should be changed, in my opinion. In addition, failing in loading configuration files or misuse of permissions for wikis is a critical bug which should be handled with priority and solved in days, not years. Samat (talk) 14:01, 29 November 2020 (UTC)

I think it is possible that this was fixed in September 2020 when Matmarex fixed phab:T237191 (exact change [1] ). It should be still confirmed though, but I think that root cause for both bugs were same. --Zache (talk) 21:25, 30 November 2020 (UTC)
And answer to myself. It is not likely fixed yet as configuration was separated to Configs that must be set before FlaggedRevsHooks::onExtensionFunctions and Configs that must be set after FlaggedRevsHooks::onExtensionFunctions and the later which contais user permissions is still same as before and thus likely broken. (thanks to Tgr for noticing this) --Zache (talk) 23:20, 30 November 2020 (UTC)

This is relatively easy to work around for Flagged Revisions specifically (just configure those permissions elsewhere). The fact that our configuration system, which determines who can access various functionality, including highly sensitive ones, is broken and we have no idea why, is deeply scary. --Tgr (talk) 03:19, 13 December 2020 (UTC)

Voting

  •   Support (proposer) Samat (talk) 19:04, 8 December 2020 (UTC)
  •   Support MarioSuperstar77 (talk) 21:11, 8 December 2020 (UTC)
  •   Support * Pppery * it has begun 01:48, 9 December 2020 (UTC)
  •   Support Thomas Kinz (talk) 09:14, 9 December 2020 (UTC)
  •   Strong support. This has been annoying me for ages. ONUnicorn (talk) 18:23, 11 December 2020 (UTC)
  •   Support Gce (talk) 17:11, 12 December 2020 (UTC)
  •   Support Tgr (talk) 03:17, 13 December 2020 (UTC)
  •   Support Tacsipacsi (talk) 20:20, 14 December 2020 (UTC)
  •   Support --Zache (talk) 21:23, 14 December 2020 (UTC)
  •   Support Kvng (talk) 14:36, 16 December 2020 (UTC)
  •   SupportEihel (talk) 19:45, 16 December 2020 (UTC)